Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in connection URL calcuation in ServerApp #761

Merged

Conversation

jhamet93
Copy link
Contributor

Addresses an unintentional regression in the calculation of the connection_url property of the ServerApp detailed in issue: #743

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #761 (7e124c3) into main (e0c126f) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   70.80%   70.74%   -0.06%     
==========================================
  Files          62       62              
  Lines        7627     7629       +2     
  Branches     1220     1221       +1     
==========================================
- Hits         5400     5397       -3     
- Misses       1850     1854       +4     
- Partials      377      378       +1     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.42% <66.66%> (+0.06%) ⬆️
jupyter_server/services/kernels/handlers.py 57.80% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c126f...7e124c3. Read the comment docs.

@blink1073 blink1073 added the bug label Mar 27, 2022
@blink1073
Copy link
Contributor

@meeseeksdev please run pre-commit

@lumberbot-app
Copy link

lumberbot-app bot commented Mar 27, 2022

Would you mind installing me on your fork so that I can update your branch?
Click hereto do that, and follow the instructions to add your fork.I'm going to try to push as a maintainer but this may not work.

@lumberbot-app
Copy link

lumberbot-app bot commented Mar 27, 2022

I've applied "pre-commit" and pushed. You may have trouble pushing further
commits, but feel free to force push and ask me to run again.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 4087b98 into jupyter-server:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants